Optimizations #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings a bunch of optimizations to prettier_print, mostly in terms of cutting down on allocations.
Most of the common patterns are now using pre-allocated doc nodes instead of building new ones every time. For nodes that are markers like BreakParent or Trim, there are now instances that correspond to them like BREAK_PARENT and TRIM which are used.
For breakables, we now have methods that encapsulate the most common use cases. These are:
In terms of a couple of breaking changes:
The last optimization is that if_break and if_flat now check if the parent group is already broken. If it is, then they don't bother inserting the content into the final tree. This can cut down on the number of nodes in the final tree by quite a lot.